dev docs: add documentation to the rocksdb configuration #392
+74
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsasari
suggested changes
Nov 20, 2024
| //! That last point isn't yet implemented, as we need some changes to the rust rocksdb bindings, see [rust-rocksdb#937]. No issue has yet been | ||
| //! found with this as our db is almost only append-only - but this should nonetheless be fixed. (FIXME) | ||
| //! | ||
| //! This configuration makes a lot of sense because we making a blockchain node. All of our db writes are very big, all or nothing and infrequent. |
Contributor
There was a problem hiding this comment.
This configuration makes a lot of sense in the context of a blockchain node.
Trantorian1
requested changes
Nov 27, 2024
Contributor
Trantorian1
left a comment
Trantorian1
left a comment
There was a problem hiding this comment.
A few spelling mistakes. Also some of @shamsasari's RFCs have not been addressed yet.
Contributor
|
@cchudant could you address RFC in this PR? |
Contributor
|
Hi @cchudant , are there any pending RFCs in this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
resolves #231
fixes the outstanding review comments in #379
cc @shamsasari
(note:
the thing i mention about snapshots for consistent db reads in the module docs is something i wanted to fix for a very long time, it's not a new concern. i was waiting for #292 to be merged to fix it.
it can't cause any problem in block production mode so that's why it hasn't yet been fixed)